]> granicus.if.org Git - llvm/commit
Optimize metadata node fields for CHECK-ability
authorDuncan P. N. Exon Smith <dexonsmith@apple.com>
Sat, 28 Feb 2015 23:21:38 +0000 (23:21 +0000)
committerDuncan P. N. Exon Smith <dexonsmith@apple.com>
Sat, 28 Feb 2015 23:21:38 +0000 (23:21 +0000)
commit9b18dbfe831919302a914aaf7530cf105ed1fd83
treeee4bb01da7360621678ca42224048629b98e1e79
parent776b3011a7f9f4d9777f715f859d082579b858d2
Optimize metadata node fields for CHECK-ability

While gaining practical experience hand-updating CHECK lines (for moving
the new debug info hierarchy into place),  I learnt a few things about
CHECK-ability of the specialized node assembly output.

  - The first part of a `CHECK:` is to identify the "right" node (this
    is especially true if you intend to use the new `CHECK-SAME`
    feature, since the first CHECK needs to identify the node correctly
    before you can split the line).
      - If there's a `tag:`, it should go first.
      - If there's a `name:`, it should go next (followed by the
        `linkageName:`, if any).
      - If there's a `scope:`, it should follow after that.
  - When a node type supports multiple DW_TAGs, but one is implied by
    its name and is overwhelmingly more common, the `tag:` field is
    terribly uninteresting unless it's different.
      - `MDBasicType` is almost always `DW_TAG_base_type`.
      - `MDTemplateValueParameter` is almost always
        `DW_TAG_template_value_parameter`.
  - Printing `name: ""` doesn't improve CHECK-ability, and there are far
    more nodes than I realized that are commonly nameless.
  - There are a few other fields that similarly aren't very interesting
    when they're empty.

This commit updates the `AsmWriter` as suggested above (and makes
necessary changes in `LLParser` for round-tripping).

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@230877 91177308-0d34-0410-b5e6-96231b3b80d8
13 files changed:
lib/AsmParser/LLParser.cpp
lib/IR/AsmWriter.cpp
test/Assembler/debug-info.ll
test/Assembler/invalid-mdbasictype-missing-tag.ll [deleted file]
test/Assembler/invalid-mdtemplatevalueparameter-missing-tag.ll [deleted file]
test/Assembler/invalid-mdtemplatevalueparameter-missing-type.ll [deleted file]
test/Assembler/mdglobalvariable.ll
test/Assembler/mdimportedentity.ll
test/Assembler/mdlocalvariable.ll
test/Assembler/mdnamespace.ll
test/Assembler/mdsubprogram.ll
test/Assembler/mdtemplateparameter.ll
test/Assembler/mdtype-large-values.ll