]> granicus.if.org Git - postgresql/commit
projects / postgresql / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: d2de44c) | patch
In recordExtensionInitPriv(), keep the scan til we're done with it
authorStephen Frost <sfrost@snowman.net>
Sat, 16 Apr 2016 01:57:15 +0000 (21:57 -0400)
committerStephen Frost <sfrost@snowman.net>
Sat, 16 Apr 2016 01:57:15 +0000 (21:57 -0400)
commit99f2f3c19ae7d6aa2950a9bdb549217c5a60d941
tree703eb73dea293b1cc79888cb9ebabafaaee9b17dtree | snapshot
parentd2de44c2ce5c697a2de8089fb377816b2387107acommit | diff
In recordExtensionInitPriv(), keep the scan til we're done with it

For reasons of sheer brain fade, we (I) was calling systable_endscan()
immediately after systable_getnext() and expecting the tuple returned
by systable_getnext() to still be valid.

That's clearly wrong.  Move the systable_endscan() down below the tuple
usage.

Discovered initially by Pavel Stehule and then also by Alvaro.

Add a regression test based on Alvaro's testing.
src/backend/catalog/aclchk.c diff | blob | history
src/test/modules/test_extensions/Makefile diff | blob | history
src/test/modules/test_extensions/expected/test_extensions.out diff | blob | history
src/test/modules/test_extensions/sql/test_extensions.sql diff | blob | history
src/test/modules/test_extensions/test_ext6--1.0.sql [new file with mode: 0644] blob
src/test/modules/test_extensions/test_ext6.control [new file with mode: 0644] blob
Unnamed repository; edit this file 'description' to name the repository.