]> granicus.if.org Git - apache/commit
Merge r1429582 from trunk:
authorJim Jagielski <jim@apache.org>
Mon, 11 Mar 2013 16:33:22 +0000 (16:33 +0000)
committerJim Jagielski <jim@apache.org>
Mon, 11 Mar 2013 16:33:22 +0000 (16:33 +0000)
commit99dfef5dc9ec5f9da030055dcfc265db157642e9
treeb3dda19175f03f45c2e02e17f01f69d7d6ddbc4d
parentdd5210831e2f6680b3bd33913132a8bf64e7b3b8
Merge r1429582 from trunk:

According to my testing, one special case of 'log_xlate_error', i.e. EES_INCOMPLETE_CHAR,
 is 13x (!!!) faster with the use 'ap_bin2hex' instead of apr_snprintf(..., "%02X" + srlen for each character.

Output is *not* exactly the same. It was uppercase, now it is lowercase.
It is just for logging, so I don't think it is an issue.
Should it be, a call to ap_strtoupper can be added.

So sad it is just for logging in case of error... no real speedup to be expected in real life .

Submitted by: jailletc36
Reviewed/backported by: jim

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/2.4.x@1455221 13f79535-47bb-0310-9956-ffa450edef68
STATUS
modules/filters/mod_charset_lite.c