]> granicus.if.org Git - clang/commit
Don't suppress warning about dllimport on typedefs etc. in MicrosoftExt mode
authorHans Wennborg <hans@hanshq.net>
Fri, 23 May 2014 20:16:41 +0000 (20:16 +0000)
committerHans Wennborg <hans@hanshq.net>
Fri, 23 May 2014 20:16:41 +0000 (20:16 +0000)
commit98a84f6794a8928fee755d3d9f9cf78949d34027
tree3329c58b59750534ed8ccafe4f3932e39be9b25d
parentcb6ec96eeea42e18e786ac66e6eb10b06454ca05
Don't suppress warning about dllimport on typedefs etc. in MicrosoftExt mode

It's true the MSVC doesn't warn about dllimport when applied to e.g. a typedef,
but that applies to dllexport too. I'd like us to be consistent, and I think
the right thing to do is to warn.

The original test that came with implementing the old behaviour doesn't provide
a good motivation, and it said it was checking that we're not repoting an *error*,
which is still true since this is just a warning.

There are plenty of tests e.g. in Sema/dllimport.c to check that we do warn
about dllimport on non functions or variables.

Differential Revision: http://reviews.llvm.org/D3832

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@209546 91177308-0d34-0410-b5e6-96231b3b80d8
include/clang/Basic/Attr.td
lib/Sema/SemaDeclAttr.cpp
test/Rewriter/dllimport-typedef.c [deleted file]