]> granicus.if.org Git - postgresql/commit
Fix file descriptor leak after failure of a \setshell command in pgbench.
authorTom Lane <tgl@sss.pgh.pa.us>
Tue, 16 Dec 2014 18:31:42 +0000 (13:31 -0500)
committerTom Lane <tgl@sss.pgh.pa.us>
Tue, 16 Dec 2014 18:32:38 +0000 (13:32 -0500)
commit961df18531b9e13be31b024329053a9d9e1556af
tree16650cea21d8feeec430797e0c8ea711d30d01da
parent662eebdc63376c2118197081c2e51bb531b6b1db
Fix file descriptor leak after failure of a \setshell command in pgbench.

If the called command fails to return data, runShellCommand forgot to
pclose() the pipe before returning.  This is fairly harmless in the current
code, because pgbench would then abandon further processing of that client
thread; so no more than nclients descriptors could be leaked this way.  But
it's not hard to imagine future improvements whereby that wouldn't be true.
In any case, it's sloppy coding, so patch all branches.  Found by Coverity.
contrib/pgbench/pgbench.c