]> granicus.if.org Git - postgresql/commit
Fix over-aggressive sanity check in misc_sanity.sql.
authorTom Lane <tgl@sss.pgh.pa.us>
Mon, 28 Aug 2017 14:14:20 +0000 (10:14 -0400)
committerTom Lane <tgl@sss.pgh.pa.us>
Mon, 28 Aug 2017 14:14:46 +0000 (10:14 -0400)
commit95e28b7f0c9e30cb636f58b5aa351e5f8ae3a473
tree3f3ac54389ec9dc0bbcd816fe37e434c9ffc647c
parent46596f8d6b5dfdb836fa79788614a3786bc3cbb6
Fix over-aggressive sanity check in misc_sanity.sql.

Fix thinko in commit 8be8510cf: it's okay to have dbid == 0 in normal
(non-pin) entries in pg_shdepend, because global objects such as
databases are entered that way.  The test would pass so long as it
was run in a cluster containing no databases/tablespaces owned by,
or granted to, roles other than the bootstrap superuser.  That's the
expected situation for "make check", but for "make installcheck", not
so much.

Reported by Ryan Murphy.

Discussion: https://postgr.es/m/CAHeEsBc6EQe0mxGBKDXAwJbntgfvoAd5MQC-5362SmC3Tng_6g@mail.gmail.com
src/test/regress/expected/misc_sanity.out
src/test/regress/sql/misc_sanity.sql