]> granicus.if.org Git - postgresql/commit
Fix infinite-loop risk in fixempties() stage of regex compilation.
authorTom Lane <tgl@sss.pgh.pa.us>
Thu, 7 Mar 2013 16:51:08 +0000 (11:51 -0500)
committerTom Lane <tgl@sss.pgh.pa.us>
Thu, 7 Mar 2013 16:51:08 +0000 (11:51 -0500)
commit957b9c0c452ce166957c981c63c9a46fa32f64c1
tree96b708c3a8a5d00ad85f5bb4c060015652974ce3
parent51616dcda47a416ef3169dc3d1f3ca199d7a4a5d
Fix infinite-loop risk in fixempties() stage of regex compilation.

The previous coding of this function could get into situations where it
would never terminate, because successive passes would re-add EMPTY arcs
that had been removed by the previous pass.  Rewrite the function
completely using a new algorithm that is guaranteed to terminate, and
also seems to be usually faster than the old one.  Per Tcl bugs 3604074
and 3606683.

Tom Lane and Don Porter
src/backend/regex/regc_nfa.c
src/backend/regex/regcomp.c
src/test/regress/expected/regex.out
src/test/regress/sql/regex.sql