]> granicus.if.org Git - php/commit
Make run-tests.php compatible with php 7.0-7.2
authorTyson Andre <tysonandre775@hotmail.com>
Sat, 23 Mar 2019 20:47:10 +0000 (16:47 -0400)
committerNikita Popov <nikita.ppv@gmail.com>
Mon, 25 Mar 2019 12:58:22 +0000 (13:58 +0100)
commit936356bf1e080ee9a9c05d2808d903a1f8a8004c
treeae2f725052ae3e69b1fe88abf30dcbe57f9ff6f7
parent8b94042c470ceb83432a169f7df042f508c1c400
Make run-tests.php compatible with php 7.0-7.2

Motivation:
As an extension author, I want to speed up running tests in php <=7.3,
both locally and in CI (e.g. with valgrind).
This can be done by manually copying php 7.4's run-tests.php script
to replace the one generated by `phpize`

- list() doesn't work in php 7.0
- negative string offset doesn't work in php 7.2

If run-tests.php can be copied from php-src without any manual patches,
that would be the easiest.

Related to #2822 - I didn't see any discussion for/against compatibility
with older php versions
run-tests.php