]> granicus.if.org Git - python/commit
bpo-33694: Fix race condition in asyncio proactor (GH-7498) (GH-7499)
authorMiss Islington (bot) <31488909+miss-islington@users.noreply.github.com>
Thu, 7 Jun 2018 22:49:34 +0000 (15:49 -0700)
committerVictor Stinner <vstinner@redhat.com>
Thu, 7 Jun 2018 22:49:34 +0000 (00:49 +0200)
commit8fa398d5cecec80990c5642b081f52cbbc6a05eb
tree86bc015d3012af82e3be8d0150406c4bdd52c19b
parent0aee3bea197af51de3a30e4665eaa2971a681fbb
bpo-33694: Fix race condition in asyncio proactor (GH-7498) (GH-7499)

The cancellation of an overlapped WSARecv() has a race condition
which causes data loss because of the current implementation of
proactor in asyncio.

No longer cancel overlapped WSARecv() in _ProactorReadPipeTransport
to work around the race condition.

Remove the optimized recv_into() implementation to get simple
implementation of pause_reading() using the single _pending_data
attribute.

Move _feed_data_to_bufferred_proto() to protocols.py.

Remove set_protocol() method which became useless.
(cherry picked from commit 79790bc35fe722a49977b52647f9b5fe1deda2b7)

Co-authored-by: Victor Stinner <vstinner@redhat.com>
Lib/asyncio/proactor_events.py
Lib/asyncio/protocols.py
Lib/asyncio/sslproto.py
Lib/test/test_asyncio/test_proactor_events.py
Lib/test/test_asyncio/test_sslproto.py
Misc/NEWS.d/next/Library/2018-06-07-23-51-00.bpo-33694.F1zIR1.rst [new file with mode: 0644]