]> granicus.if.org Git - clang/commit
CodeGen: __uuidof should work even with an incomplete _GUID type
authorDavid Majnemer <david.majnemer@gmail.com>
Thu, 15 Aug 2013 19:59:14 +0000 (19:59 +0000)
committerDavid Majnemer <david.majnemer@gmail.com>
Thu, 15 Aug 2013 19:59:14 +0000 (19:59 +0000)
commit8effeda3d2cfd92abaebc5ac46fc3693c69f66f3
treee5537290686007001dce27c527591bba170ab1f2
parente1f1ff66bf4e9507bb534244a5a5d0c950316a2f
CodeGen: __uuidof should work even with an incomplete _GUID type

Summary:
We would crash in CodeGen::CodeGenModule::EmitUuidofInitializer
because our attempt to enter CodeGen::CodeGenModule::EmitConstantValue
will be foiled: the type of the constant value is incomplete.

Instead, create an unnamed type with the proper layout on all platforms.
Punt the problem of wrongly defined struct _GUID types to the user.
(It's impossible because the TU may never get to see the type and thus
we can't verify that it is suitable.)

This fixes PR16856.

Reviewers: rsmith, rnk, thakis

Reviewed By: rnk

CC: cfe-commits
Differential Revision: http://llvm-reviews.chandlerc.com/D1375

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@188481 91177308-0d34-0410-b5e6-96231b3b80d8
lib/CodeGen/CGExpr.cpp
lib/CodeGen/CodeGenModule.cpp
test/CodeGenCXX/microsoft-uuidof-unsupported-target.cpp [deleted file]
test/CodeGenCXX/microsoft-uuidof.cpp