]> granicus.if.org Git - python/commit
#4871: check that zipfile password is bytes, and give useful error message.
authorR. David Murray <rdmurray@bitdance.com>
Tue, 21 Dec 2010 21:53:37 +0000 (21:53 +0000)
committerR. David Murray <rdmurray@bitdance.com>
Tue, 21 Dec 2010 21:53:37 +0000 (21:53 +0000)
commit8d855d83046dd8a55cd216e642470191e6eab55f
tree994b94cdb6b1bfda618c4754792ea0696da0fdbf
parent7f8f41808b82b5e4812bc2e2d484a6fc8f02295c
#4871: check that zipfile password is bytes, and give useful error message.

Previously passing a string in as the password would fail either with
an assertion error or a TypeError with a confusing error message.
Note that a string can't be accepted since zipfile has no way to
guess what encoding should be used to turn it into bytes.

Patch by Victor Stinner.
Lib/test/test_zipfile.py
Lib/zipfile.py
Misc/NEWS