]> granicus.if.org Git - postgresql/commit
Rework activation of commit timestamps during recovery
authorMichael Paquier <michael@paquier.xyz>
Wed, 26 Sep 2018 01:25:54 +0000 (10:25 +0900)
committerMichael Paquier <michael@paquier.xyz>
Wed, 26 Sep 2018 01:25:54 +0000 (10:25 +0900)
commit8d28bf500f6536e295e9c3d7b85cdfec1c4dc913
treea149dd193726d6a842be0c1833be5642182e4494
parent10763358c3f0df48d2ae39b49b0c93be149cceab
Rework activation of commit timestamps during recovery

The activation and deactivation of commit timestamp tracking has not
been handled consistently for a primary or standbys at recovery.  The
facility can be activated at three different moments of recovery:
- The beginning, where a primary would use the GUC value for the
decision-making, and where a standby relies on the contents of the
control file.
- When replaying a XLOG_PARAMETER_CHANGE record at redo.
- The end, where both primary and standby rely on the GUC value.

Using the GUC value for a primary at the beginning of recovery causes
problems with commit timestamp access when doing crash recovery.
Particularly, when replaying transaction commits, it could be possible
that an attempt to read commit timestamps is done for a transaction
which committed at a moment when track_commit_timestamp was disabled.

A test case is added to reproduce the failure.  The test works down to
v11 as it takes advantage of transaction commits within procedures.

Reported-by: Hailong Li
Author: Masahiko Sawasa, Michael Paquier
Reviewed-by: Kyotaro Horiguchi
Discussion: https://postgr.es/m/11224478-a782-203b-1f17-e4797b39bdf0@qunar.com
Backpatch-through: 9.5, where commit timestamps have been introduced.
src/backend/access/transam/commit_ts.c
src/backend/access/transam/xlog.c
src/test/modules/commit_ts/t/004_restart.pl