]> granicus.if.org Git - postgresql/commit
Avoid "invalid memory alloc request size" while reading pg_stat_activity.
authorTom Lane <tgl@sss.pgh.pa.us>
Tue, 7 May 2019 15:41:37 +0000 (11:41 -0400)
committerTom Lane <tgl@sss.pgh.pa.us>
Tue, 7 May 2019 15:41:37 +0000 (11:41 -0400)
commit8d0ddccec6366a2851da7d350b33659203aa644b
tree6cf111487dca2ba88d89c88de4fb95c42810dc63
parentb753bc0c84e51c200ec7de6cefb6f689d13fef62
Avoid "invalid memory alloc request size" while reading pg_stat_activity.

On a 64-bit machine, if you set track_activity_query_size and
max_connections such that their product exceeds 1GB, shared memory
setup will still succeed (given enough RAM), but attempts to read
pg_stat_activity fail with "invalid memory alloc request size".
Work around that by using MemoryContextAllocHuge to allocate the
local copy of the activity strings.  Using the "huge" API costs us
nothing extra in normal cases, and it seems better than throwing
an error and/or explaining to people why they can't do this.

This situation seems insanely profligate today, but who knows what
people will consider normal in ten or twenty years?  So let's fix it
in HEAD but not worry about a back-patch.

Per report from James Tomson.

Discussion: https://postgr.es/m/1CFDCCD6-B268-48D8-85C8-400D2790B2C3@pushd.com
src/backend/postmaster/pgstat.c