]> granicus.if.org Git - postgresql/commit
Avoid unnecessary use of strncpy in a couple of places in ecpg.
authorTom Lane <tgl@sss.pgh.pa.us>
Sat, 16 Jun 2018 18:58:11 +0000 (14:58 -0400)
committerTom Lane <tgl@sss.pgh.pa.us>
Sat, 16 Jun 2018 18:58:21 +0000 (14:58 -0400)
commit8c924855456eff392391eba49cb02ae581a12898
tree673af1d7ddc8cd6da2b4adfab2a78a1a714aaec5
parent18933261589c9547d5c517cdc05f25362cce412a
Avoid unnecessary use of strncpy in a couple of places in ecpg.

Use of strncpy with a length limit based on the source, rather than
the destination, is non-idiomatic and draws warnings from gcc 8.
Replace with memcpy, which does exactly the same thing in these cases,
but with less chance for confusion.

Backpatch to all supported branches.

Discussion: https://postgr.es/m/21789.1529170195@sss.pgh.pa.us
src/interfaces/ecpg/ecpglib/descriptor.c
src/interfaces/ecpg/pgtypeslib/common.c