]> granicus.if.org Git - llvm/commit
[DebugInfo@O2][LoopVectorize] pr39024: Vectorized code linenos step through loop...
authorOrlando Cazalet-Hyams <orlando.hyams@sony.com>
Tue, 7 May 2019 15:37:38 +0000 (15:37 +0000)
committerOrlando Cazalet-Hyams <orlando.hyams@sony.com>
Tue, 7 May 2019 15:37:38 +0000 (15:37 +0000)
commit8c101025dc22bf9f1c33bb035e5a2dcde289befa
tree30f66f486320cc4afbcf03e22cdfad59b5721cdc
parent4079beaf423d96252de6644da19695f682793c31
[DebugInfo@O2][LoopVectorize] pr39024: Vectorized code linenos step through loop even after completion

Summary:
Bug: https://bugs.llvm.org/show_bug.cgi?id=39024

The bug reports that a vectorized loop is stepped through 4 times and each step through the loop seemed to show a different path. I found two problems here:

A) An incorrect line number on a preheader block (for.body.preheader) instruction causes a step into the loop before it begins.
B) Instructions in the middle block have different line numbers which give the impression of another iteration.

In this patch I give all of the middle block instructions the line number of the scalar loop latch terminator branch. This seems to provide the smoothest debugging experience because the vectorized loops will always end on this line before dropping into the scalar loop. To solve problem A I have altered llvm::SplitBlockPredecessors to accommodate loop header blocks.

Reviewers: samsonov, vsk, aprantl, probinson, anemet, hfinkel

Reviewed By: hfinkel

Subscribers: bjope, jmellorcrummey, hfinkel, gbedwell, hiraditya, zzheng, llvm-commits

Tags: #llvm, #debug-info

Differential Revision: https://reviews.llvm.org/D60831

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@360162 91177308-0d34-0410-b5e6-96231b3b80d8
lib/Transforms/Utils/BasicBlockUtils.cpp
lib/Transforms/Vectorize/LoopVectorize.cpp
test/Transforms/LoopSimplify/dbg-loc.ll
test/Transforms/LoopSimplify/do-preheader-dbg.ll [new file with mode: 0755]
test/Transforms/LoopSimplify/for-preheader-dbg.ll [new file with mode: 0755]
test/Transforms/LoopUnroll/runtime-loop1.ll
test/Transforms/LoopVectorize/X86/vectorization-remarks-missed.ll
test/Transforms/LoopVectorize/X86/vectorization-remarks-profitable.ll
test/Transforms/LoopVectorize/debugloc.ll
test/Transforms/LoopVectorize/fix-reduction-dbg.ll [new file with mode: 0755]
test/Transforms/LoopVectorize/unsafe-dep-remark.ll