]> granicus.if.org Git - postgresql/commit
Avoid possibly accessing off the end of memory in SJIS2004 conversion.
authorTom Lane <tgl@sss.pgh.pa.us>
Tue, 6 Sep 2011 18:50:28 +0000 (14:50 -0400)
committerTom Lane <tgl@sss.pgh.pa.us>
Tue, 6 Sep 2011 18:50:44 +0000 (14:50 -0400)
commit8b81b99b89de186aeda9baabf4e1b6bd792d54b9
treeffa62c5f7fcc6868abcf931e25a19541376272f6
parent460bfd07b38f6495314c01499fca49f5f4a68a38
Avoid possibly accessing off the end of memory in SJIS2004 conversion.

The code in shift_jis_20042euc_jis_2004() would fetch two bytes even when
only one remained in the string.  Since conversion functions aren't
supposed to assume null-terminated input, this poses a small risk of
fetching past the end of memory and incurring SIGSEGV.  No such crash has
been identified in the field, but we've certainly seen the equivalent
happen in other code paths, so patch this one all the way back.

Report and patch by Noah Misch.
src/backend/utils/mb/conversion_procs/euc2004_sjis2004/euc2004_sjis2004.c