]> granicus.if.org Git - postgresql/commit
postgres_fdw: Account for triggers in non-direct remote UPDATE planning.
authorEtsuro Fujita <efujita@postgresql.org>
Thu, 13 Jun 2019 08:59:09 +0000 (17:59 +0900)
committerEtsuro Fujita <efujita@postgresql.org>
Thu, 13 Jun 2019 08:59:09 +0000 (17:59 +0900)
commit8b6da83d162cb0ac9f6d21082727bbd45c972c53
treedcc92fe5a15abb1349f78a77d52cfc115b46a78c
parent7dc6ae37def50b5344c157eee5e029a09359f8ee
postgres_fdw: Account for triggers in non-direct remote UPDATE planning.

Previously, in postgresPlanForeignModify, we planned an UPDATE operation
on a foreign table so that we transmit only columns that were explicitly
targets of the UPDATE, so as to avoid unnecessary data transmission, but
if there were BEFORE ROW UPDATE triggers on the foreign table, those
triggers might change values for non-target columns, in which case we
would miss sending changed values for those columns.  Prevent optimizing
away transmitting all columns if there are BEFORE ROW UPDATE triggers on
the foreign table.

This is an oversight in commit 7cbe57c34 which added triggers on foreign
tables, so apply the patch all the way back to 9.4 where that came in.

Author: Shohei Mochizuki
Reviewed-by: Amit Langote
Discussion: https://postgr.es/m/201905270152.x4R1q3qi014550@toshiba.co.jp
contrib/postgres_fdw/expected/postgres_fdw.out
contrib/postgres_fdw/postgres_fdw.c
contrib/postgres_fdw/sql/postgres_fdw.sql