]> granicus.if.org Git - postgresql/commit
Fix more memory leaks in failure path in buildACLCommands.
authorTom Lane <tgl@sss.pgh.pa.us>
Wed, 11 Feb 2015 23:35:23 +0000 (18:35 -0500)
committerTom Lane <tgl@sss.pgh.pa.us>
Wed, 11 Feb 2015 23:35:23 +0000 (18:35 -0500)
commit8b63f89498f2e3ff0e1d420b023ccb76c34c2cda
tree67c6f8d7732bd5bf283769bc33233e706b96e03b
parent9be9ac4254cf32e98980ad89320e4e8b0ca515a7
Fix more memory leaks in failure path in buildACLCommands.

We already had one go at this issue in commit d73b7f973db5ec7e, but we
failed to notice that buildACLCommands also leaked several PQExpBuffers
along with a simply malloc'd string.  This time let's try to make the
fix a bit more future-proof by eliminating the separate exit path.

It's still not exactly critical because pg_dump will curl up and die on
failure; but since the amount of the potential leak is now several KB,
it seems worth back-patching as far as 9.2 where the previous fix landed.

Per Coverity, which evidently is smarter than clang's static analyzer.
src/bin/pg_dump/dumputils.c