]> granicus.if.org Git - postgresql/commit
Fix pg_dump to handle inherited NOT VALID check constraints correctly.
authorTom Lane <tgl@sss.pgh.pa.us>
Thu, 1 Oct 2015 20:19:49 +0000 (16:19 -0400)
committerTom Lane <tgl@sss.pgh.pa.us>
Thu, 1 Oct 2015 20:20:13 +0000 (16:20 -0400)
commit8ab4a6bd3f1a300313eab04d52b0c9a4003f3e43
treeea8788223bacfaf713fc2f8451775fb741d65b91
parentf12e814b88d8082804bbc8b827469d8068e7252c
Fix pg_dump to handle inherited NOT VALID check constraints correctly.

This case seems to have been overlooked when unvalidated check constraints
were introduced, in 9.2.  The code would attempt to dump such constraints
over again for each child table, even though adding them to the parent
table is sufficient.

In 9.2 and 9.3, also fix contrib/pg_upgrade/Makefile so that the "make
clean" target fully cleans up after a failed test.  This evidently got
dealt with at some point in 9.4, but it wasn't back-patched.  I ran into
it while testing this fix ...

Per bug #13656 from Ingmar Brouns.
src/bin/pg_dump/pg_dump.c
src/test/regress/expected/alter_table.out
src/test/regress/sql/alter_table.sql