]> granicus.if.org Git - postgresql/commit
Fix GiST buffering build bug, which caused "failed to re-find parent" errors.
authorHeikki Linnakangas <heikki.linnakangas@iki.fi>
Thu, 16 Aug 2012 09:42:11 +0000 (12:42 +0300)
committerHeikki Linnakangas <heikki.linnakangas@iki.fi>
Thu, 16 Aug 2012 09:56:24 +0000 (12:56 +0300)
commit89911b3ab848915dd64d21ca3d3537470c93f89c
tree0285c9e6686ee083ea403c322f350548c20212c0
parentde3773d951bfc85d8860295248cf91db524a4ef8
Fix GiST buffering build bug, which caused "failed to re-find parent" errors.

We use a hash table to track the parents of inner pages, but when inserting
to a leaf page, the caller of gistbufferinginserttuples() must pass a
correct block number of the leaf's parent page. Before gistProcessItup()
descends to a child page, it checks if the downlink needs to be adjusted to
accommodate the new tuple, and updates the downlink if necessary. However,
updating the downlink might require splitting the page, which might move the
downlink to a page to the right. gistProcessItup() doesn't realize that, so
when it descends to the leaf page, it might pass an out-of-date parent block
number as a result. Fix that by returning the block a tuple was inserted to
from gistbufferinginserttuples().

This fixes the bug reported by Zdeněk Jílovec.
src/backend/access/gist/gist.c
src/backend/access/gist/gistbuild.c
src/include/access/gist_private.h