]> granicus.if.org Git - clang/commit
Clean up our handling of local instantiation scopes, which keep track
authorDouglas Gregor <dgregor@apple.com>
Fri, 30 Apr 2010 18:55:50 +0000 (18:55 +0000)
committerDouglas Gregor <dgregor@apple.com>
Fri, 30 Apr 2010 18:55:50 +0000 (18:55 +0000)
commit895162da2d52f4243f61081d7436de66af4503fc
tree190cae43675e176ce9b2c08fdf16e55ab36b829a
parent25cf7b4e9198026c8872203874d04b36831af969
Clean up our handling of local instantiation scopes, which keep track
of the mapping from local declarations to their instantiated
counterparts during template instantiation. Previously, we tried to do
some unholy merging of local instantiation scopes that involved
storing a single hash table along with an "undo" list on the
side... which was ugly, and never handled function parameters
properly.

Now, we just keep separate hash tables for each local instantiation
scope, and "combining" two scopes means that we'll look in each of the
combined hash tables. The combined scope stack is rarely deep, and
this makes it easy to avoid the "undo" issues we were hitting. Also,
I've simplified the logic for function parameters: if we're declaring
a function and we need the function parameters to live longer, we just
push them back into the local instantiation scope where we need them.

Fixes PR6990.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@102732 91177308-0d34-0410-b5e6-96231b3b80d8
lib/Sema/Sema.h
lib/Sema/SemaTemplate.cpp
lib/Sema/SemaTemplateInstantiate.cpp
lib/Sema/SemaTemplateInstantiateDecl.cpp
lib/Sema/TreeTransform.h
test/SemaTemplate/instantiate-function-params.cpp