]> granicus.if.org Git - postgresql/commit
Fix oversight in PG_RE_THROW processing: it's entirely possible that there
authorTom Lane <tgl@sss.pgh.pa.us>
Wed, 2 May 2007 15:32:42 +0000 (15:32 +0000)
committerTom Lane <tgl@sss.pgh.pa.us>
Wed, 2 May 2007 15:32:42 +0000 (15:32 +0000)
commit88f1fd29897df477f0af3c5ffcefe53c697a6ff3
treee279b7a47d27c209a2c2019c3b3069a346a49483
parentd6013a34f29777254eb5e285a3468960f449de50
Fix oversight in PG_RE_THROW processing: it's entirely possible that there
isn't any place to throw the error to.  If so, we should treat the error
as FATAL, just as we would have if it'd been thrown outside the PG_TRY
block to begin with.

Although this is clearly a *potential* source of bugs, it is not clear
at the moment whether it is an *actual* source of bugs; there may not
presently be any PG_TRY blocks in code that can be reached with no outer
longjmp catcher.  So for the moment I'm going to be conservative and not
back-patch this.  The change breaks ABI for users of PG_RE_THROW and hence
might create compatibility problems for loadable modules, so we should not
put it into released branches without proof that it's needed.
src/backend/utils/error/elog.c
src/include/utils/elog.h