]> granicus.if.org Git - postgresql/commit
Use snprintf not sprintf in pg_waldump's timestamptz_to_str.
authorTom Lane <tgl@sss.pgh.pa.us>
Sat, 16 Jun 2018 18:45:47 +0000 (14:45 -0400)
committerTom Lane <tgl@sss.pgh.pa.us>
Sat, 16 Jun 2018 18:45:47 +0000 (14:45 -0400)
commit8870e2978fc5db5741229f5cddc7bcc24ee52000
tree1f6812dc9d4b12c39bd7e35bed8760b0ccaa2556
parente951f66deadbe78da83b2d1919d39883d098fdff
Use snprintf not sprintf in pg_waldump's timestamptz_to_str.

This could only cause an issue if strftime returned a ridiculously
long timezone name, which seems unlikely; and it wouldn't qualify
as a security problem even then, since pg_waldump (nee pg_xlogdump)
is a debug tool not part of the server.  But gcc 8 has started issuing
warnings about it, so let's use snprintf and be safe.

Backpatch to 9.3 where this code was added.

Discussion: https://postgr.es/m/21789.1529170195@sss.pgh.pa.us
src/bin/pg_xlogdump/compat.c