]> granicus.if.org Git - clang/commit
Warn about suspicious implicit conversions from floating point to bool
authorHans Wennborg <hans@hanshq.net>
Tue, 28 Aug 2012 15:44:30 +0000 (15:44 +0000)
committerHans Wennborg <hans@hanshq.net>
Tue, 28 Aug 2012 15:44:30 +0000 (15:44 +0000)
commit88617a24adafed42e33d196972f97c72d9a5e0a0
tree23a4bc1ce2e82c892fe6d5d723942124f0cebdc1
parent9438016db2332aca8b53fd953da06128373cc5be
Warn about suspicious implicit conversions from floating point to bool

This warns in two specific situations:

1) For potentially swapped function arguments, e.g.

     void foo(bool, float);
     foo(1.7, false);

2) Misplaced brackets around function call arguments, e.g.

     bool InRange = fabs(a - b < delta);

   Where the last argument in a function call is implicitly converted
   from bool to float, and the function returns a float which gets
   implicitly converted to bool.

Patch by Andreas Eckleder!

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@162763 91177308-0d34-0410-b5e6-96231b3b80d8
include/clang/Basic/DiagnosticGroups.td
include/clang/Basic/DiagnosticSemaKinds.td
lib/Sema/SemaChecking.cpp
test/SemaCXX/warn-implicit-conversion-floating-point-to-bool.cpp [new file with mode: 0644]