]> granicus.if.org Git - llvm/commit
Convenience/safety fix for llvm::sys::Execute(And|No)Wait
authorAlexander Kornienko <alexfh@google.com>
Wed, 13 Sep 2017 17:03:37 +0000 (17:03 +0000)
committerAlexander Kornienko <alexfh@google.com>
Wed, 13 Sep 2017 17:03:37 +0000 (17:03 +0000)
commit87e117df596739e50867b307d591861da8ace36e
treea492fdbca5c75f75f9ada4062e4e9f12424c8380
parentf6e4c7d70e68fe9e2e91a3926b9de394774f9cbd
Convenience/safety fix for llvm::sys::Execute(And|No)Wait

Summary:
Change the type of the Redirects parameter of llvm::sys::ExecuteAndWait,
ExecuteNoWait and other APIs that wrap them from `const StringRef **` to
`ArrayRef<Optional<StringRef>>`, which is safer and simplifies the use of these
APIs (no more local StringRef variables just to get a pointer to).

Corresponding clang changes will be posted as a separate patch.

Reviewers: bkramer

Reviewed By: bkramer

Subscribers: vsk, llvm-commits

Differential Revision: https://reviews.llvm.org/D37563

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@313155 91177308-0d34-0410-b5e6-96231b3b80d8
12 files changed:
include/llvm/Support/Program.h
lib/Support/GraphWriter.cpp
lib/Support/Program.cpp
lib/Support/Signals.cpp
lib/Support/Unix/Program.inc
lib/Support/Windows/Program.inc
tools/bugpoint/OptimizerDriver.cpp
tools/bugpoint/ToolRunner.cpp
tools/dsymutil/MachOUtils.cpp
tools/llvm-cov/CodeCoverage.cpp
unittests/Support/ProgramTest.cpp
utils/not/not.cpp