]> granicus.if.org Git - postgresql/commit
Hand code string to integer conversion for performance.
authorAndres Freund <andres@anarazel.de>
Sun, 22 Jul 2018 21:58:01 +0000 (14:58 -0700)
committerAndres Freund <andres@anarazel.de>
Sun, 22 Jul 2018 21:58:23 +0000 (14:58 -0700)
commit86eaf208ea048936df6be77276a246d3f92e9620
treed0b7d529bba5f072457c003c951d05ca2aa90caa
parent3522d0eaba5a976f09a48810dd25dff6ab3565df
Hand code string to integer conversion for performance.

As benchmarks show, using libc's string-to-integer conversion is
pretty slow. At least part of the reason for that is that strtol[l]
have to be more generic than what largely is required inside pg.

This patch considerably speeds up int2/int4 input (int8 already was
already using hand-rolled code).

Most of the existing pg_atoi callers have been converted. But as one
requires pg_atoi's custom delimiter functionality, and as it seems
likely that there's external pg_atoi users, it seems sensible to just
keep pg_atoi around.

Author: Andres Freund
Reviewed-By: Robert Haas
Discussion: https://postgr.es/m/20171208214437.qgn6zdltyq5hmjpk@alap3.anarazel.de
13 files changed:
contrib/spi/refint.c
doc/src/sgml/sources.sgml
src/backend/libpq/pqmq.c
src/backend/replication/libpqwalreceiver/libpqwalreceiver.c
src/backend/tsearch/wparser_def.c
src/backend/utils/adt/arrayutils.c
src/backend/utils/adt/int.c
src/backend/utils/adt/int8.c
src/backend/utils/adt/numutils.c
src/backend/utils/adt/varlena.c
src/include/utils/builtins.h
src/test/regress/expected/int2.out
src/test/regress/expected/select_parallel.out