]> granicus.if.org Git - postgresql/commit
Clean up handling of dropped columns in NAMEDTUPLESTORE RTEs.
authorTom Lane <tgl@sss.pgh.pa.us>
Wed, 6 Sep 2017 14:41:05 +0000 (10:41 -0400)
committerTom Lane <tgl@sss.pgh.pa.us>
Wed, 6 Sep 2017 14:41:05 +0000 (10:41 -0400)
commit8689e38263af7755b8100203e325a5953ed1e602
treea059405f6284a8e0818669cb7f1bcc91414d4efb
parent0b554e4e63a4ba4852c01951311713e23acdae02
Clean up handling of dropped columns in NAMEDTUPLESTORE RTEs.

The NAMEDTUPLESTORE patch piggybacked on the infrastructure for
TABLEFUNC/VALUES/CTE RTEs, none of which can ever have dropped columns,
so the possibility was ignored most places.  Fix that, including adding a
specification to parsenodes.h about what it's supposed to look like.

In passing, clean up assorted comments that hadn't been maintained
properly by said patch.

Per bug #14799 from Philippe Beaudoin.  Back-patch to v10.

Discussion: https://postgr.es/m/20170906120005.25630.84360@wrigleys.postgresql.org
src/backend/optimizer/util/relnode.c
src/backend/parser/parse_relation.c
src/backend/parser/parse_target.c
src/backend/utils/adt/ruleutils.c
src/include/nodes/parsenodes.h