]> granicus.if.org Git - zfs/commit
OpenZFS 8081 - Compiler warnings in zdb
authorBrian Behlendorf <behlendorf1@llnl.gov>
Fri, 27 Oct 2017 19:46:35 +0000 (12:46 -0700)
committerGitHub <noreply@github.com>
Fri, 27 Oct 2017 19:46:35 +0000 (12:46 -0700)
commit867959b5887c5211c520ad10ef8d12990a6d79fa
tree67f85de9d6658c01108a3542e9f6e585dc30edff
parenta94d38c0f382c16244912de83a7356ae35e63322
OpenZFS 8081 - Compiler warnings in zdb

Fix compiler warnings in zdb.  With these changes, FreeBSD can compile
zdb with all compiler warnings enabled save -Wunused-parameter.

usr/src/cmd/zdb/zdb.c
usr/src/cmd/zdb/zdb_il.c
usr/src/uts/common/fs/zfs/sys/sa.h
usr/src/uts/common/fs/zfs/sys/spa.h
Fix numerous warnings, including:
* const-correctness
* shadowing global definitions
* signed vs unsigned comparisons
* missing prototypes, or missing static declarations
* unused variables and functions
* Unreadable array initializations
* Missing struct initializers

usr/src/cmd/zdb/zdb.h
Add a header file to declare common symbols

usr/src/lib/libzpool/common/sys/zfs_context.h
usr/src/uts/common/fs/zfs/arc.c
usr/src/uts/common/fs/zfs/dbuf.c
usr/src/uts/common/fs/zfs/spa.c
usr/src/uts/common/fs/zfs/txg.c
Add a function prototype for zk_thread_create, and ensure that every
callback supplied to this function actually matches the prototype.

usr/src/cmd/ztest/ztest.c
usr/src/uts/common/fs/zfs/sys/zil.h
usr/src/uts/common/fs/zfs/zfs_replay.c
usr/src/uts/common/fs/zfs/zvol.c
Add a function prototype for zil_replay_func_t, and ensure that
every function of this type actually matches the prototype.

usr/src/uts/common/fs/zfs/sys/refcount.h
Change FTAG so it discards any constness of __func__, necessary
since existing APIs expect it passed as void *.

Porting Notes:
- Many of these fixes have already been applied to Linux.  For
  consistency the OpenZFS version of a change was applied if the
  warning was addressed in an equivalent but different fashion.

Reviewed by: Matthew Ahrens <mahrens@delphix.com>
Reviewed by: Prakash Surya <prakash.surya@delphix.com>
Authored by: Alan Somers <asomers@gmail.com>
Approved by: Richard Lowe <richlowe@richlowe.net>
Ported-by: Brian Behlendorf <behlendorf1@llnl.gov>
OpenZFS-issue: https://www.illumos.org/issues/8081
OpenZFS-commit: https://github.com/openzfs/openzfs/commit/843abe1b8a
Closes #6787
15 files changed:
cmd/zdb/Makefile.am
cmd/zdb/zdb.c
cmd/zdb/zdb.h [new file with mode: 0644]
cmd/zdb/zdb_il.c
cmd/ztest/ztest.c
include/sys/refcount.h
include/sys/zfs_znode.h
include/sys/zil.h
module/zfs/arc.c
module/zfs/dbuf.c
module/zfs/spa.c
module/zfs/txg.c
module/zfs/zfs_replay.c
module/zfs/zil.c
module/zfs/zvol.c