]> granicus.if.org Git - postgresql/commit
Limit values of archive_timeout, post_auth_delay, auth_delay.milliseconds.
authorTom Lane <tgl@sss.pgh.pa.us>
Sun, 18 Nov 2012 22:15:11 +0000 (17:15 -0500)
committerTom Lane <tgl@sss.pgh.pa.us>
Sun, 18 Nov 2012 22:15:11 +0000 (17:15 -0500)
commit83d48a81f8e25f16a133f56874f1bcdee7838841
treee14c50411e3e8f05abff9c4a79b8696da9a846ec
parent89067bc16a1d1ea5bf131b3529e01d208f2e34c0
Limit values of archive_timeout, post_auth_delay, auth_delay.milliseconds.

The previous definitions of these GUC variables allowed them to range
up to INT_MAX, but in point of fact the underlying code would suffer
overflows or other errors with large values.  Reduce the maximum values
to something that won't misbehave.  There's no apparent value in working
harder than this, since very large delays aren't sensible for any of
these.  (Note: the risk with archive_timeout is that if we're late
checking the state, the timestamp difference it's being compared to
might overflow.  So we need some amount of slop; the choice of INT_MAX/2
is arbitrary.)

Per followup investigation of bug #7670.  Although this isn't a very
significant fix, might as well back-patch.
contrib/auth_delay/auth_delay.c
src/backend/utils/misc/guc.c