]> granicus.if.org Git - postgresql/commit
Fix YA unwanted behavioral difference with operator_precedence_warning.
authorTom Lane <tgl@sss.pgh.pa.us>
Wed, 15 Feb 2017 19:44:00 +0000 (14:44 -0500)
committerTom Lane <tgl@sss.pgh.pa.us>
Wed, 15 Feb 2017 19:44:00 +0000 (14:44 -0500)
commit8350aae4f18a158980c17f56c39a707f4ac168cc
tree29f0825247d4ec7c7be5b70b19bd78dc60e55382
parent3e51859ebc910744e04bc35907fa3d29fd68eb4b
Fix YA unwanted behavioral difference with operator_precedence_warning.

Jeff Janes noted that the error cursor position shown for some errors
would vary when operator_precedence_warning is turned on.  We'd prefer
that option to have no undocumented effects, so this isn't desirable.
To fix, make sure that an AEXPR_PAREN node has the same exprLocation
as its child node.

(Note: it would be a little cheaper to use @2 here instead of an
exprLocation call, but there are cases where that wouldn't produce
the identical answer, so don't do it like that.)

Back-patch to 9.5 where this feature was introduced.

Discussion: https://postgr.es/m/CAMkU=1ykK+VhhcQ4Ky8KBo9FoaUJH3f3rDQB8TkTXi-ZsBRUkQ@mail.gmail.com
src/backend/parser/gram.y