]> granicus.if.org Git - postgresql/commit
Create an improved FDW option validator function for contrib/dblink.
authorTom Lane <tgl@sss.pgh.pa.us>
Wed, 10 Oct 2012 20:53:08 +0000 (16:53 -0400)
committerTom Lane <tgl@sss.pgh.pa.us>
Wed, 10 Oct 2012 20:53:08 +0000 (16:53 -0400)
commit8255566f9d479fdfeea09da3141d26afdbb5abe2
tree00d54179dbdb5ea74c7fc782b001400993ff894b
parent392b2e5010ddce24bcb1a9d38adb1d06f01fb543
Create an improved FDW option validator function for contrib/dblink.

dblink now has its own validator function dblink_fdw_validator(), which is
better than the core function postgresql_fdw_validator() because it gets
the list of legal options from libpq instead of having a hard-wired list.

Make the dblink extension module provide a standard foreign data wrapper
dblink_fdw that encapsulates use of this validator, and recommend use of
that wrapper instead of making up wrappers on the fly.

Unfortunately, because ad-hoc wrappers *were* recommended practice
previously, it's not clear when we can get rid of postgresql_fdw_validator
without causing upgrade problems.  But this is a step in the right
direction.

Shigeru Hanada, reviewed by KaiGai Kohei
contrib/dblink/Makefile
contrib/dblink/dblink--1.0--1.1.sql [new file with mode: 0644]
contrib/dblink/dblink--1.1.sql [moved from contrib/dblink/dblink--1.0.sql with 94% similarity]
contrib/dblink/dblink.c
contrib/dblink/dblink.control
contrib/dblink/dblink.h
contrib/dblink/expected/dblink.out
contrib/dblink/sql/dblink.sql
doc/src/sgml/dblink.sgml