]> granicus.if.org Git - llvm/commit
[ValueTracking] Revert r310583 which enabled functionality that still is
authorChandler Carruth <chandlerc@gmail.com>
Mon, 14 Aug 2017 07:03:24 +0000 (07:03 +0000)
committerChandler Carruth <chandlerc@gmail.com>
Mon, 14 Aug 2017 07:03:24 +0000 (07:03 +0000)
commit821fe0674f41e7b48e734d058d866347ec7e277c
tree253e9f7ab5cca33d6603f17e84154de83beb229f
parent7de7a0fee84a69a56c398749c47ebdf4ab15d3fc
[ValueTracking] Revert r310583 which enabled functionality that still is
causing compile time issues.

Moreover, the patch *deleted* the flag in addition to changing the
default, and links to a code review that doesn't even discuss the flag
and just has an update to a Clang test case.

I've followed up on the commit thread to ask for numbers on compile time
at this point, leaving the flag in place until things stabilize, and
pointing at specific code that seems to exhibit excessive compile time
with this patch.

Original commit message for r310583:
"""
[ValueTracking] Enabling ValueTracking patch by default (recommit). Part 2.

The original patch was an improvement to IR ValueTracking on
non-negative integers. It has been checked in to trunk (D18777,
r284022). But was disabled by default due to performance regressions.
Perf impact has improved. The patch would be enabled by default.
""""

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@310816 91177308-0d34-0410-b5e6-96231b3b80d8
lib/Analysis/ValueTracking.cpp
test/Analysis/ValueTracking/non-negative-phi-bits.ll [deleted file]