]> granicus.if.org Git - postgresql/commit
Zero padding in replication origin's checkpointed on disk-state.
authorAndres Freund <andres@anarazel.de>
Sun, 23 Apr 2017 22:48:31 +0000 (15:48 -0700)
committerAndres Freund <andres@anarazel.de>
Sun, 23 Apr 2017 22:54:58 +0000 (15:54 -0700)
commit81ff04deda21e016e0e1d4ea1755ccb14c47c871
tree75096c5f9d90a05b546d849ad910ff392a49be35
parenta66e01bbcc8808674ade41d38cfba711a36b8b15
Zero padding in replication origin's checkpointed on disk-state.

This seems to be largely cosmetic, avoiding valgrind bleats and the
like. The uninitialized padding influences the CRC of the on-disk
entry, but because it's also used when verifying the CRC, that doesn't
cause spurious failures.  Backpatch nonetheless.

It's a bit unfortunate that contrib/test_decoding/sql/replorigin.sql
doesn't exercise the checkpoint path, but checkpoints are fairly
expensive on weaker machines, and we'd have to stop/start for that to
be meaningful.

Author: Andres Freund
Discussion: https://postgr.es/m/20170422183123.w2jgiuxtts7qrqaq@alap3.anarazel.de
Backpatch: 9.5, where replication origins were introduced
src/backend/replication/logical/origin.c