]> granicus.if.org Git - php/commit
Make mysqli_warning constructor private
authorNikita Popov <nikita.ppv@gmail.com>
Thu, 24 Sep 2020 14:51:47 +0000 (16:51 +0200)
committerNikita Popov <nikita.ppv@gmail.com>
Sun, 27 Sep 2020 20:08:24 +0000 (22:08 +0200)
commit8138ed73d73209024ad8500a4ab565b84259a1bf
tree670befb84ba795db9587270f86ba85f4786561dc
parent02dc9ce6e595b15b332e2e0c6b5737fb475a9d50
Make mysqli_warning constructor private

The constructor was already effectively inaccessible (protected
on a final class). This just makes it more obvious and removes
the implementation in favor of directly throwing.

Per the removed test, this was an unfinished feature, and I don't
think it makes a lot of sense to finish it -- the
mysqli_stmt::get_warnings() interface makes more sense than
direct construction.

Closes GH-6208.
ext/mysqli/mysqli.stub.php
ext/mysqli/mysqli_arginfo.h
ext/mysqli/mysqli_warning.c
ext/mysqli/tests/mysqli_class_mysqli_warning.phpt [deleted file]