]> granicus.if.org Git - graphviz/commit
fix corruption of user shape characteristics during EPSF initialization
authorMatthew Fernandez <matthew.fernandez@gmail.com>
Sun, 6 Mar 2022 22:28:23 +0000 (14:28 -0800)
committerMatthew Fernandez <matthew.fernandez@gmail.com>
Sat, 12 Mar 2022 21:04:53 +0000 (13:04 -0800)
commit80f864b5c0e796964aa8c993ad286ecd8fa92878
treed174b214e62ef53b89b4b0bccd823162f3a2b688
parent2e0d6e9a190550040c0e01475191a83653242c76
fix corruption of user shape characteristics during EPSF initialization

From the surrounding context, it is clear this code was intending to set `h`,
the height of the shape, not overwrite the `y` coordinate it had previously set
for the shape. This change not only fixes the overwrite of `us->y` but fixes a
read of uninitialized memory in `us->h` by the caller of this function.

It is not clear to me what the full user-visible effect of this change is.
CHANGELOG.md
lib/common/psusershape.c