]> granicus.if.org Git - postgresql/commit
Fix pg_recvlogical not to fsync output when it's a tty or pipe.
authorAndres Freund <andres@anarazel.de>
Tue, 7 Jul 2015 10:47:44 +0000 (12:47 +0200)
committerAndres Freund <andres@anarazel.de>
Tue, 7 Jul 2015 11:07:34 +0000 (13:07 +0200)
commit8022b0a35f7c4e71908a878c8c412b5c2ae8536c
tree777787fde9b2e0282ccd882032ab88f2daeb0e6b
parent2867f26fecafc6d9930eb751abdd7b80359a6f51
Fix pg_recvlogical not to fsync output when it's a tty or pipe.

The previous coding tried to handle possible failures when fsyncing a
tty or pipe fd by accepting EINVAL - but apparently some
platforms (windows, OSX) don't reliably return that. So instead check
whether the output fd refers to a pipe or a tty when opening it.

Reported-By: Olivier Gosseaume, Marko Tiikkaja
Discussion: 559AF98B.3050901@joh.to

Backpatch to 9.4, where pg_recvlogical was added.
src/bin/pg_basebackup/pg_recvlogical.c