]> granicus.if.org Git - postgresql/commit
Fix a violation of WAL coding rules in the recent patch to include an
authorTom Lane <tgl@sss.pgh.pa.us>
Mon, 24 Aug 2009 02:18:32 +0000 (02:18 +0000)
committerTom Lane <tgl@sss.pgh.pa.us>
Mon, 24 Aug 2009 02:18:32 +0000 (02:18 +0000)
commit7fc7a7c4d082bfbd579f49e92b046dd51f1faf5f
treee19eb3522dff2a147be330e6388980e4ff2be803
parentcab9a0656c36739f59277b34fea8ab9438395869
Fix a violation of WAL coding rules in the recent patch to include an
"all tuples visible" flag in heap page headers.  The flag update *must*
be applied before calling XLogInsert, but heap_update and the tuple
moving routines in VACUUM FULL were ignoring this rule.  A crash and
replay could therefore leave the flag incorrectly set, causing rows
to appear visible in seqscans when they should not be.  This might explain
recent reports of data corruption from Jeff Ross and others.

In passing, do a bit of editorialization on comments in visibilitymap.c.
src/backend/access/heap/heapam.c
src/backend/access/heap/visibilitymap.c
src/backend/commands/vacuum.c
src/backend/commands/vacuumlazy.c
src/include/access/heapam.h
src/include/access/visibilitymap.h