]> granicus.if.org Git - apache/commit
As I understand it, this test is supposed to read like so:
authorCliff Woolley <jwoolley@apache.org>
Fri, 31 Aug 2001 05:05:58 +0000 (05:05 +0000)
committerCliff Woolley <jwoolley@apache.org>
Fri, 31 Aug 2001 05:05:58 +0000 (05:05 +0000)
commit7f6b8db6786ae53144385478857f7e7200f04819
tree3d10e7634064a5222eecb6c8195c5ed2a2a2fc66
parent62c8307ac978f0fd432169177400b8ff5f23e8ac
As I understand it, this test is supposed to read like so:

----------------------------------------------------
if the base paths are the same
    if (strncmp(rnew->filename, fdir, fdirlen) == 0

and there's more stuff in the new filename than just the base path
        && rnew->filename[fdirlen]

and that stuff contains no slashes
        && ap_strchr_c(rnew->filename + fdirlen, '/') == NULL)
----------------------------------------------------

Assuming that's a correct translation, which I believe to be the case
(and which also seems to jive with the previous version of the test),
then that first part darned well better check == 0, as opposed to != 0.
strncmp returns 0 when they match.  =-)

And voila,
"All tests successful, 1 test skipped."
is the result from httpd-test

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@90842 13f79535-47bb-0310-9956-ffa450edef68
server/request.c