]> granicus.if.org Git - php/commit
- Make fclose() actually close stream, even when the resource refcount is > 1.
authorGustavo André dos Santos Lopes <cataphract@php.net>
Mon, 21 Mar 2011 02:58:54 +0000 (02:58 +0000)
committerGustavo André dos Santos Lopes <cataphract@php.net>
Mon, 21 Mar 2011 02:58:54 +0000 (02:58 +0000)
commit7f2937223dec01f23e8bffb1824bee3420a703f2
treef42f4443d59b5f5ae8dfd21a89acc93d80e985d0
parent2034e143410117ac0c85f46e724cc33ec80157eb
- Make fclose() actually close stream, even when the resource refcount is > 1.
  This reverts the fix for bug #24557.
- Make php_stream_free delete the stream from the resources list, not merely
  decrease its refcount, as a single call to zend_list_delete does.
#Not worth the risk merging to 5.3. While change #2 may prevent some segfaults,
#a quick and dirty survey to the codebase only showed calls to php_stream_close
#or php_stream_free on streams allocated in the same function, which would have
#refcount == 1. May be reconsidered.
UPGRADING
ext/standard/file.c
ext/standard/tests/file/fclose_variation1.phpt [new file with mode: 0644]
main/streams/streams.c