]> granicus.if.org Git - postgresql/commit
Fix a gradual memory leak in ExecReScanAgg(). Because the aggregation
authorNeil Conway <neilc@samurai.com>
Wed, 8 Aug 2007 18:07:03 +0000 (18:07 +0000)
committerNeil Conway <neilc@samurai.com>
Wed, 8 Aug 2007 18:07:03 +0000 (18:07 +0000)
commit7dd8d4673f21ca63d754f2015f8b075e0dc79b91
treef45e587c410d4ed89b004d9c170bfa2dfb212837
parentf614a2b50842c5ced90cd5c5af802684028510a9
Fix a gradual memory leak in ExecReScanAgg(). Because the aggregation
hash table is allocated in a child context of the agg node's memory
context, MemoryContextReset() will reset but *not* delete the child
context. Since ExecReScanAgg() proceeds to build a new hash table
from scratch (in a new sub-context), this results in leaking the
header for the previous memory context. Therefore, use
MemoryContextResetAndDeleteChildren() instead.

Credit: My colleague Sailesh Krishnamurthy at Truviso for isolating
the cause of the leak.
src/backend/executor/nodeAgg.c