]> granicus.if.org Git - python/commit
Forward-port of r52136,52138: a review of overflow-detecting code.
authorArmin Rigo <arigo@tunes.org>
Wed, 4 Oct 2006 12:17:45 +0000 (12:17 +0000)
committerArmin Rigo <arigo@tunes.org>
Wed, 4 Oct 2006 12:17:45 +0000 (12:17 +0000)
commit7ccbca93a27e22f0b06316b0d9760fbf7b19cbda
tree63a92638c4b4faa7bcd2979eadeef5aa33a1abd9
parent0d2f498a4cebb428a28fdc54b277ecede5ebc1c7
Forward-port of r52136,52138: a review of overflow-detecting code.

* unified the way intobject, longobject and mystrtoul handle
  values around -sys.maxint-1.

* in general, trying to entierely avoid overflows in any computation
  involving signed ints or longs is extremely involved.  Fixed a few
  simple cases where a compiler might be too clever (but that's all
  guesswork).

* more overflow checks against bad data in marshal.c.

* 2.5 specific: fixed a number of places that were still confusing int
  and Py_ssize_t.  Some of them could potentially have caused
  "real-world" breakage.

* list.pop(x): fixing overflow issues on x was messy.  I just reverted
  to PyArg_ParseTuple("n"), which does the right thing.  (An obscure
  test was trying to give a Decimal to list.pop()... doesn't make
  sense any more IMHO)

* trying to write a few tests...
19 files changed:
Lib/test/list_tests.py
Lib/test/test_builtin.py
Lib/test/test_long.py
Misc/NEWS
Modules/cPickle.c
Objects/abstract.c
Objects/fileobject.c
Objects/intobject.c
Objects/listobject.c
Objects/longobject.c
Objects/stringobject.c
Objects/typeobject.c
Objects/unicodeobject.c
Python/errors.c
Python/getargs.c
Python/marshal.c
Python/modsupport.c
Python/mystrtoul.c
Python/sysmodule.c