]> granicus.if.org Git - python/commit
Merge: #17443: Fix buffering in IMAP4_stream.
authorR David Murray <rdmurray@bitdance.com>
Tue, 19 Mar 2013 17:56:01 +0000 (13:56 -0400)
committerR David Murray <rdmurray@bitdance.com>
Tue, 19 Mar 2013 17:56:01 +0000 (13:56 -0400)
commit7889944b83cf04cefb45cd658644298218eac5db
treefc1f6d1ff2f4ddc45d5726b3d3212b33a46510c0
parente185341bfa177932b00a03a1d8b1d0e0e7795919
parentfcb6d6a3b3bfba67927ced18dd648ba889e14f4c
Merge: #17443: Fix buffering in IMAP4_stream.

In Python2 Popen uses *FILE objects, which wind up buffering even though
subprocess defaults to no buffering.  In Python3, subprocess streams really
are unbuffered by default, but the imaplib code assumes read is buffered.  This
patch uses the default buffer size from the io module to get buffered streams
from Popen.

Much debugging work and patch by Diane Trout.

The imap protocol is too complicated to write a test for this simple
change with our current level of test infrastructure.
Lib/imaplib.py
Misc/ACKS
Misc/NEWS