]> granicus.if.org Git - postgresql/commit
Prefer pg_any_to_server/pg_server_to_any over pg_do_encoding_conversion.
authorTom Lane <tgl@sss.pgh.pa.us>
Sun, 23 Feb 2014 21:59:05 +0000 (16:59 -0500)
committerTom Lane <tgl@sss.pgh.pa.us>
Sun, 23 Feb 2014 21:59:05 +0000 (16:59 -0500)
commit769065c1b2471f484bb48bb58a8bdcf1d12a419c
treedc0344a494ceabe955b403b992f4092ec4140f8b
parent49c817eab78c6f0ce8c3bf46766b73d6cf3190b7
Prefer pg_any_to_server/pg_server_to_any over pg_do_encoding_conversion.

A large majority of the callers of pg_do_encoding_conversion were
specifying the database encoding as either source or target of the
conversion, meaning that we can use the less general functions
pg_any_to_server/pg_server_to_any instead.

The main advantage of using the latter functions is that they can make use
of a cached conversion-function lookup in the common case that the other
encoding is the current client_encoding.  It's notationally cleaner too in
most cases, not least because of the historical artifact that the latter
functions use "char *" rather than "unsigned char *" in their APIs.

Note that pg_any_to_server will apply an encoding verification step in
some cases where pg_do_encoding_conversion would have just done nothing.
This seems to me to be a good idea at most of these call sites, though
it partially negates the performance benefit.

Per discussion of bug #9210.
12 files changed:
contrib/pg_stat_statements/pg_stat_statements.c
contrib/sslinfo/sslinfo.c
src/backend/commands/extension.c
src/backend/snowball/dict_snowball.c
src/backend/tsearch/ts_locale.c
src/backend/utils/adt/pg_locale.c
src/backend/utils/adt/xml.c
src/backend/utils/mb/mbutils.c
src/pl/plperl/plperl.c
src/pl/plperl/plperl_helpers.h
src/pl/plpython/plpy_util.c
src/pl/tcl/pltcl.c