]> granicus.if.org Git - clang/commit
arc-repeated-use-of-weak should not warn about IBOutlet properties
authorBob Wilson <bob.wilson@apple.com>
Wed, 25 May 2016 05:41:57 +0000 (05:41 +0000)
committerBob Wilson <bob.wilson@apple.com>
Wed, 25 May 2016 05:41:57 +0000 (05:41 +0000)
commit756a4a5956a4c162021fa96f5cca81188811f7ed
treef0d9d8442d7345f110e90ea504d55ae55d0f0af1
parentff8e258e28d0cbffe39fed0caa560f6e85293544
arc-repeated-use-of-weak should not warn about IBOutlet properties

Revision r211132 was supposed to disable -Warc-repeated-use-of-weak for
Objective-C properties marked with the IBOutlet attribute. Those properties
are supposed to be weak but they are only accessed from the main thread
so there is no risk of asynchronous updates setting them to nil. That
combination makes -Warc-repeated-use-of-weak very noisy. The previous
change only handled one kind of access to weak IBOutlet properties.
Instead of trying to add checks for all the different kinds of property
accesses, this patch removes the previous special case check and adds a
check at the point where the diagnostic is reported. rdar://21366461

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@270665 91177308-0d34-0410-b5e6-96231b3b80d8
lib/Sema/AnalysisBasedWarnings.cpp
lib/Sema/SemaPseudoObject.cpp
test/SemaObjC/iboutlet.m