]> granicus.if.org Git - postgresql/commit
Revert "Add log_statement_sample_rate parameter"
authorTomas Vondra <tomas.vondra@postgresql.org>
Sun, 4 Aug 2019 18:29:00 +0000 (20:29 +0200)
committerTomas Vondra <tomas.vondra@postgresql.org>
Sun, 4 Aug 2019 21:38:27 +0000 (23:38 +0200)
commit75506195da81d75597a4025b72f8367e6c45f60d
tree55d6df111735a0710ce13d2b831deb3f1e83d728
parent4f9ed8f3c5ef0034c98dd34549f85d8c72aab9ad
Revert "Add log_statement_sample_rate parameter"

This reverts commit 88bdbd3f746049834ae3cc972e6e650586ec3c9d.

As committed, statement sampling used the existing duration threshold
(log_min_duration_statement) when decide which statements to sample.
The issue is that even the longest statements are subject to sampling,
and so may not end up logged. An improvement was proposed, introducing
a second duration threshold, but it would not be backwards compatible.
So we've decided to revert this feature - the separate threshold should
be part of the feature itself.

Discussion: https://postgr.es/m/CAFj8pRDS8tQ3Wviw9%3DAvODyUciPSrGeMhJi_WPE%2BEB8%2B4gLL-Q%40mail.gmail.com
doc/src/sgml/config.sgml
src/backend/tcop/postgres.c
src/backend/utils/misc/guc.c
src/backend/utils/misc/postgresql.conf.sample
src/include/utils/guc.h