]> granicus.if.org Git - clang/commit
[Modules] Warning for module declarations lacking 'framework' qualifier
authorBruno Cardoso Lopes <bruno.cardoso@gmail.com>
Fri, 1 Jun 2018 01:26:18 +0000 (01:26 +0000)
committerBruno Cardoso Lopes <bruno.cardoso@gmail.com>
Fri, 1 Jun 2018 01:26:18 +0000 (01:26 +0000)
commit73d4cf2ee5b4705992e18873f658656f023b653b
tree53674988e83809e0fdfb237d005eef8eb441b69c
parent31db11052916d8a76e9a07d6039b0c0603879bba
[Modules] Warning for module declarations lacking 'framework' qualifier

When a module declaration for a framework lacks the 'framework'
qualifier, the listed headers aren't found (because there's no
trigger for the special framework style path lookup) and the module
is silently not built. This leads to frameworks not being modularized
by accident, which is pretty bad.

Add a warning and suggest the user to add the 'framework' qualifier
when we can prove that it's the case.

rdar://problem/39193062

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@333718 91177308-0d34-0410-b5e6-96231b3b80d8
include/clang/Basic/DiagnosticGroups.td
include/clang/Basic/DiagnosticLexKinds.td
include/clang/Lex/ModuleMap.h
lib/Lex/ModuleMap.cpp
test/Modules/Inputs/incomplete-framework-module/Foo.framework/Headers/Foo.h [new file with mode: 0644]
test/Modules/Inputs/incomplete-framework-module/Foo.framework/Headers/FooB.h [new file with mode: 0644]
test/Modules/Inputs/incomplete-framework-module/Foo.framework/Modules/module.modulemap [new file with mode: 0644]
test/Modules/incomplete-framework-module.m [new file with mode: 0644]