]> granicus.if.org Git - python/commit
projects / python / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 27b7f9f) | patch
PySocket_getaddrinfo(): fix two refcount bugs, both having to do with
authorGuido van Rossum <guido@python.org>
Fri, 12 Oct 2001 18:59:27 +0000 (18:59 +0000)
committerGuido van Rossum <guido@python.org>
Fri, 12 Oct 2001 18:59:27 +0000 (18:59 +0000)
commit716aac0448ef9fb6f3fd8c82237a7e73e9adb307
treeecf1df387292593f4ca3b5bf83d9951044825077tree | snapshot
parent27b7f9f91e6e88a6607c05f6e47bba5016225a94commit | diff
PySocket_getaddrinfo(): fix two refcount bugs, both having to do with
a misunderstanding of the refcont behavior of the 'O' format code in
PyArg_ParseTuple() and Py_BuildValue(), respectively.

- pobj is only a borrowed reference, so should *not* be DECREF'ed at
  the end.  This was the cause of SF bug #470635.

- The Py_BuildValue() call would leak the object produced by
  makesockaddr().  (I found this by eyeballing the code.)
Modules/socketmodule.c diff | blob | history
Unnamed repository; edit this file 'description' to name the repository.