]> granicus.if.org Git - clang/commit
[profile] Do not cache __llvm_profile_get_filename result
authorVedant Kumar <vsk@apple.com>
Fri, 18 Oct 2019 23:33:40 +0000 (23:33 +0000)
committerVedant Kumar <vsk@apple.com>
Fri, 18 Oct 2019 23:33:40 +0000 (23:33 +0000)
commit7000556ec0f00c6c96211b4e5c82032476f37cb5
treec1407e59f8713b2b42865551a3c0728ca2cf01e7
parentbe1f932eb807ad248842b1669c3312c29e45f86d
[profile] Do not cache __llvm_profile_get_filename result

When the %m filename pattern is used, the filename is unique to each
image, so the cached value is wrong.

It struck me that the full filename isn't something that's recomputed
often, so perhaps it doesn't need to be cached at all. David Li pointed
out we can go further and just hide lprofCurFilename. This may regress
workflows that depend on using the set-filename API to change filenames
across all loaded DSOs, but this is expected to be very rare.

rdar://55137071

Differential Revision: https://reviews.llvm.org/D69137

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@375301 91177308-0d34-0410-b5e6-96231b3b80d8
lib/Driver/ToolChains/Darwin.cpp
test/Driver/darwin-ld.c