]> granicus.if.org Git - postgresql/commit
Add locking clause for SB views for update/delete
authorStephen Frost <sfrost@snowman.net>
Thu, 26 Feb 2015 02:36:29 +0000 (21:36 -0500)
committerStephen Frost <sfrost@snowman.net>
Thu, 26 Feb 2015 02:36:29 +0000 (21:36 -0500)
commit6f9bd50eabb0a4960e94c83dac8855771c9f340d
tree4a453331105a9e8da5cc97756b2837ad25a8ed47
parent77903ede08845e55bd2a6c99b52d8da6926d6e84
Add locking clause for SB views for update/delete

In expand_security_qual(), we were handling locking correctly when a
PlanRowMark existed, but not when we were working with the target
relation (which doesn't have any PlanRowMarks, but the subquery created
for the security barrier quals still needs to lock the rows under it).

Noted by Etsuro Fujita when working with the Postgres FDW, which wasn't
properly issuing a SELECT ... FOR UPDATE to the remote side under a
DELETE.

Back-patch to 9.4 where updatable security barrier views were
introduced.

Per discussion with Etsuro and Dean Rasheed.
src/backend/optimizer/prep/prepsecurity.c
src/test/regress/expected/rowsecurity.out
src/test/regress/expected/updatable_views.out