]> granicus.if.org Git - postgresql/commit
Rethink \crosstabview's argument parsing logic.
authorTom Lane <tgl@sss.pgh.pa.us>
Fri, 15 Apr 2016 02:54:26 +0000 (22:54 -0400)
committerTom Lane <tgl@sss.pgh.pa.us>
Fri, 15 Apr 2016 02:54:31 +0000 (22:54 -0400)
commit6f0d6a507889d94a79c0d18577a0cb1ccc2b6815
tree0ee0bfe10f064a942bd5bb7f99afd5311a1809dd
parent4b74c6a40e7ac9dad7cdeb4cfd2d51ea60cfdbb5
Rethink \crosstabview's argument parsing logic.

\crosstabview interpreted its arguments in an unusual way, including
doing case-insensitive matching of unquoted column names, which is
surely not the right thing.  Rip that out in favor of doing something
equivalent to the dequoting/case-folding rules used by other psql
commands.  To keep it simple, change the syntax so that the optional
sort column is specified as a separate argument, instead of the
also-quite-unusual syntax that attached it to the colH argument with
a colon.

Also, rework the error messages to be closer to project style.
doc/src/sgml/ref/psql-ref.sgml
src/bin/psql/command.c
src/bin/psql/common.c
src/bin/psql/crosstabview.c
src/bin/psql/settings.h
src/test/regress/expected/psql_crosstab.out
src/test/regress/sql/psql_crosstab.sql